trying to figure out how to work with the new discourse-patch-triage bot when doing PRs from our own fork, and it’s a bit confusing, especially in a 3-way conversation with it and a team reviewer. is there a proper way to do this?
i can’t order it to fix it’s suggested fixes on my fork. at the moment, i am trying to address it’s replies around spec tests and i am not at all sure if i am doing it correctly - i would rather tell it to fix them since since this seems to be an option suggested.
for example, i am fixing spec tests failures on my fork for the pr but it seems like there is some friction between what i am doing and what the bot wants to do:
should i be fixing these in my fork or letting the team/bot fix them instead?
❤️ 1
isaac
Thanks lilly for the back and forth there. A couple things
To interact with the bot you need to comment @patch-triage and then you can use plain english for your request. It’s functionality is currently limited at reviewing, suggesting changes, rebasing your PR, and creating a new commit with the suggested changes.
It will not commit changes on forks, however it can still review / suggest changes. I have just made changes to make that explicit, so you will need to handle any suggested changes yourself (as you have done).
If you would like to take full advantage of the bot I suggest creating a PR directly to core rather than through your fork
Let me know if that answers your questions!
:chefs_kiss: 1❤️ 1
Lilly
thank you Isaac, that clears things up. i’m just so used to forking repos for PRs, but i’ll start doing PRs on core branches instead in cases like this - the triage bot seems pretty useful.
also, spec tests are the bane of my programming.
👍 1❤️ 1
Lilly
i don’t think i can do this anymore now that i am not staff though
I will raise the topic of allowing forks to have write access to the PR internally.
❤️ 2
system
This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.
isaac
isaac
@Lilly updates have been made and you can now
Ask for @patch-triage to review/rebase/create or commit changes for you
Everything works as expected on forks
Please take it for a spin and let me know if you run into any issues
:chefs_kiss: 1
Lilly
i sort of got the hang of the @patch-triage bot working on my fork, but i think when i told it to fix all in addition to addressing the changes it wanted, it went and fixed a bunch of code out of scope in other time intervals
system
This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.